Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test]: add unit tests for octokit module #354

Closed
1 task done
re-Tick opened this issue Mar 3, 2023 · 9 comments · May be fixed by keploy/typescript-sdk#59, keploy/typescript-sdk#71 or keploy/typescript-sdk#82
Closed
1 task done
Labels
Good First Issue Good for newcomers GSoC Issues up for GSoC Repo/@typescript-sdk Issue Related to Keploy TS-SDK Repository

Comments

@re-Tick
Copy link
Contributor

re-Tick commented Mar 3, 2023

Is there an existing feature request for this?

  • I have searched the existing issues

Summary

Currently, there are no test written in ts-sdk. And since ts-sdk does not have a application server therefore, we need to write unit tests for code coverage.

Write a unit test for integrations/octokit module's wrappedNodeFetch function. This will increase coverage for this module.

Why should this be worked on?

There should be unit tests to check the behaviour of modules individually.

@re-Tick re-Tick added the GSoC Issues up for GSoC label Mar 3, 2023
@Sonichigo Sonichigo transferred this issue from keploy/typescript-sdk Mar 3, 2023
@Sonichigo Sonichigo added Good First Issue Good for newcomers Repo/@typescript-sdk Issue Related to Keploy TS-SDK Repository labels Mar 3, 2023
@Vikrant-Khedkar
Copy link

Hey where and how am i supposed to write this tests

@Hermione2408
Copy link
Member

Hermione2408 commented Mar 7, 2023

Hey @re-Tick I was thinking of using jest to write unit test cases for the function also do we need to add it in build time script?

@re-Tick
Copy link
Contributor Author

re-Tick commented Mar 7, 2023

Hey @re-Tick I was thinking of using jest to write unit test cases for the function also do we need to add it in build time script?

Yes, we can use jest for unit-test and we have to add a test job in github action

@re-Tick
Copy link
Contributor Author

re-Tick commented Mar 7, 2023

Hey where and how am i supposed to write this tests

Unit tests have to be added for octokit module. You can use jest or motcha for writing unit tests.

@tanmay-bajaj
Copy link

Is this issue being worked upon by someone or is it available? @re-Tick

@re-Tick
Copy link
Contributor Author

re-Tick commented Mar 9, 2023

The issue is open for all. You can propose your changes in a PR and mention this issue

@Sekhar-Kumar-Dash
Copy link

@re-Tick i have updated new files in typescript sdk please review it .i had to delete the last PR because of some coding mistakes

@VishalMyla
Copy link

@re-Tick Please review this PR

@charankamarapu
Copy link
Member

Closing the issue as we dont support sdks nay more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment