fix: handle panic in case of empty test case file #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mayank Kumar <[email protected]> Signed-off-by: infinity <[email protected]>
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I have read the CLA Document and I hereby sign the CLA |
slayerjain
added a commit
that referenced
this pull request
Apr 20, 2024
|
recheck |
Comment on lines
+228
to
+230
| if yamlTestcase == nil { | ||
| return nil, errors.New("test case not present") | ||
| } |
There was a problem hiding this comment.
Hey @kidminks the logic seems to be correct but the message can be updated with
Skipped incomplete test case: Please verify that the test case is fully specified.
|
hey @kidminks any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes: #1755
Describe the changes you've made
I have added a check in testDb/utils.go > Decode() to handle nil yamlTestCase due to which panic was occurring. Decode function will return error with message test case not present incase test is empty
Type of change