Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Added the time taken by test-set #1829

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Yaxhveer
Copy link
Contributor

Related Issue

  • Info about Issue or bug

Closes: #1826

Describe the changes you've made

Added time taken by each test-set in testReportVerdict struct. Currently magenta is being used for float64 in pp color scheme.
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: Yaxhveer <[email protected]>
Signed-off-by: Yaxhveer <[email protected]>
Signed-off-by: Yaxhveer <[email protected]>
@Yaxhveer
Copy link
Contributor Author

@Sarthak160 Please review the PR.

@Sarthak160
Copy link
Member

@Yaxhveer Why not we used the same blue color to log time instead of magenta color ??

@Yaxhveer
Copy link
Contributor Author

Yaxhveer commented Apr 25, 2024

@Sarthak160 Currently here ,magenta color is defined for float types. Due you want it to be changed for every float or just for this case?

@Sarthak160
Copy link
Member

@Sarthak160 Currently here ,magenta color is defined for float types. Due you want it to be changed for every float or just for this case?

Yes, for this case only I want them to be in uniform color.

@Sarthak160
Copy link
Member

Hi @Yaxhveer, This is still logging time taken in magenta.

@Yaxhveer
Copy link
Contributor Author

Hey @Sarthak160, currently my majors are ongoing would correct it by thursday.

Signed-off-by: Yaxhveer <[email protected]>
@Yaxhveer
Copy link
Contributor Author

Yaxhveer commented May 1, 2024

Hey @Sarthak160, I changed the time to blue by updating the color for float. Though we could also use ansi colors codes but they does not work with preety printer so we would need fmt.Printf() for that.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: log time in the cli results after a test run
2 participants