Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Fixed replay starts execution before the app is started #1823

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Yaxhveer
Copy link
Contributor

@Yaxhveer Yaxhveer commented Apr 14, 2024

Related Issue

  • Info about Issue or bug

Closes: #1810
Closes: #1795

Describe the changes you've made

Currently keploy would wait till delay (5s) as provided using delay flag for user application to start , but it is required only for native env and for docker related application we have to have till the application starts or buildDelay time is completed. This pr fix this bug by adding a channel to signal the start of application or cancel the service if buildDelay is reached. Also the PR fixes the panic in keploy during an error by adding an err channel on the required goroutine which became unreachable due to the error.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: Yaxhveer <[email protected]>
@Yaxhveer Yaxhveer changed the title [BUG]: Fixed Replay starts test-set execution before the containers are started [BUG]: Fixed replay starts execution before the app is started Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant