Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized SendTelemetry function #1742

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

athul-22
Copy link

@athul-22 athul-22 commented Mar 28, 2024

Related Issue

  • Optimized SendTelemetry function.

Closes: #<issue_number>

Describe the changes you've made

Optimized the SendTelemetry function by:

  • Consolidating event struct creation.
  • Improving error handling for HTTP requests and response unmarshalling.
  • Adding deferred closing of the response body.
  • Removing unnecessary assignments and checks for streamlined code.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Code style update (formatting, local variables)
  • This change requires a documentation update

Please let us know if any test cases are added

No new test cases added.

Describe if there is any unusual behaviour of your code

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

N/A

Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

@shivamsouravjha
Copy link
Contributor

@athul-22 can you please sign the CLA.

@shivamsouravjha
Copy link
Contributor

@athul-22 any update on cla sign? and please fix the golangci-line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants