Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of version argument to installation script #1640

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Addition of version argument to installation script #1640

wants to merge 9 commits into from
+51 −6

Conversation

AhmedLotfy02
Copy link
Contributor

Related Issue

Closes: #1639

Describe the changes you've made

Addition of version argument to installation script

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

slayerjain
slayerjain requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@slayerjain slayerjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also add some docs about this usage in the docs repo.

keploy.sh Outdated
VERSION_TAG="latest"
else
# If specific version is provided, use that version
VERSION_TAG="v$VERSION"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we need to append a v to the version. Please remove that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slayerjain Done

keploy.sh Outdated
install_keploy_arm() {
curl --silent --location "https://github.com/keploy/keploy/releases/latest/download/keploy_linux_arm64.tar.gz" | tar xz -C /tmp
curl --silent --location "https://github.com/keploy/keploy/releases/download/$VERSION_TAG/keploy_linux_arm64.tar.gz" | tar xz -C /tmp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you only updated this in the arm section? There are somary other places we will need to update it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slayerjain Done adding it to amd section and docker section.

Tushar-kalsi added a commit to Tushar-kalsi/keploy that referenced this pull request Mar 4, 2024
@Tushar-kalsi
Fix-keploy#1640 Added version argument to installation script
717978d
Tushar-kalsi added a commit to Tushar-kalsi/keploy that referenced this pull request Mar 4, 2024
@Tushar-kalsi
Merge branch 'main' into Fix-keploy#1640
4c58341
Tushar-kalsi added a commit to Tushar-kalsi/keploy that referenced this pull request Mar 4, 2024
@Tushar-kalsi
Merge branch 'main' into Fix-keploy#1640
c91b727 
Adding DCO check message .

Signed-off-by: Tushar kalsi <[email protected]>
Tushar-kalsi added a commit to Tushar-kalsi/keploy that referenced this pull request Mar 4, 2024
@Tushar-kalsi
Merge remote-tracking branch 'refs/remotes/origin/Fix-#1640' into Fix-k…
74c462b 
…eploy#1640
@AhmedLotfy02
Copy link
Contributor Author

@slayerjain All edits requested are done.

Tushar-kalsi added a commit to Tushar-kalsi/keploy that referenced this pull request Mar 4, 2024
@Tushar-kalsi
Merge remote-tracking branch 'refs/remotes/origin/Fix-#1640' into Fix-k…
a3d480c 
…eploy#1640

Signed-off-by: Tushar kalsi <[email protected]>
Tushar-kalsi added a commit to Tushar-kalsi/keploy that referenced this pull request Mar 4, 2024
@Tushar-kalsi
Merge branch 'Fix-keploy#1640' of https://github.com/Tushar-kalsi/keploy
dfd1d60 
 into Fix-keploy#1640
Tushar-kalsi added a commit to Tushar-kalsi/keploy that referenced this pull request Mar 4, 2024
@Tushar-kalsi
Merge branch 'main' into Fix-keploy#1640
4143860
Tushar-kalsi added a commit to Tushar-kalsi/keploy that referenced this pull request Mar 5, 2024
@Tushar-kalsi
Fix-keploy#1640 Added version argument to installation script
917cd95 
Signed-off-by: Tushar kalsi <[email protected]>
Tushar-kalsi added a commit to Tushar-kalsi/keploy that referenced this pull request Mar 5, 2024
@Tushar-kalsi
Merge branch 'main' into Fix-keploy#1640
11dd50f
@gouravkrosx
Copy link
Member

@AhmedLotfy02 Please resolve the merge conflicts.

@AhmedLotfy02
Copy link
Contributor Author

@gouravkrosx Done.

@shivamsouravjha
Copy link
Contributor

shivamsouravjha commented Apr 29, 2024 •
edited

@AhmedLotfy02 please resolve the merge conflicts in Readme file

Tushar-kalsi added a commit to Tushar-kalsi/keploy that referenced this pull request Apr 29, 2024
@Tushar-kalsi
Merge branch 'main' into Fix-keploy#1640
b1ee858
@AhmedLotfy02
Copy link
Contributor Author

@shivamsouravjha Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slayerjain slayerjain slayerjain requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature]: Addition of version argument to installation script
4 participants
@AhmedLotfy02 @gouravkrosx @shivamsouravjha @slayerjain