-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Elixir, src/READMEs, & updated README.md #342
base: main
Are you sure you want to change the base?
Adding Elixir, src/READMEs, & updated README.md #342
Conversation
- Added a column for Elixir in each table. - Mapped the scripts. - Replaced references to multiple online compilers with one singular compiler. - Added instructions on how to access compiler sites for each language. - Centered the title. - Added the Back to top button. - Finally, linked each topic/item to its specific site.
Back to top linked to Kelvin's README header
Uploaded elixir logo in an svg format. Image credit: https://images.app.goo.gl/hXetArnAXmAZsDW18
1. CalculatePi.ex --> Approximate a value of pi 2. FactorialIterative.ex --> Returns a factorial for a given n, in an iterative manner. 3. FactorialRecursive.ex --> Returns a factorial for a given n, in an recursive manner. 4. FibonacciIterative.ex --> Returns a Fibonacci value for a given n, in an iterative manner. 5. FibonacciRecursive.ex --> Returns a Fibonacci value for a given n, in a recursive manner. 6. MaxRecursive.ex --> Find largest value in a list. 7. README.md -> Basic overview document
Added short README.md in each src folders for a quick language syntax overview. More work needs to be done in this front.
fixed markdown syntax error
fixed a syntax error in python's src/Readme file
fixed syntax error in Ruby's readme doc
Corrected syntax error in Swift's readme file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, @TestingGround00. Thank you for your contribution! Please review the feedback shared and make the changes where appropriate.
Please note, I have not reviewed the entire PR yet as it was a bit lengthy. I will need to get back to it later.
I could use some help from other contributors to review this. This is what I havent reviewed these files yet:
- README.md:
- New elixir files
- readme.md for the following directories: kotlin, ruby, rust, scala, swift.
|
||
##### 9. How to declare a Function | ||
```c | ||
return_type function_name(parameters);` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please delete the ` at the end of this line?
```c | ||
return_type function_name(parameters);` | ||
``` | ||
##### How to call a Function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we follow the same pattern as above? We were at number 9 in 'How to declare a function'.
function_name (parameters) | ||
``` | ||
|
||
##### How to define a FunctionHow to define a Function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we follow the same pattern as above? We were at number 9 in 'How to declare a function'.
```cpp | ||
return_type function_name(parameters);` | ||
``` | ||
##### How to call a Function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we follow the same pattern as you started in C? We stopped at number 8 in this readme 'Functions'.
function_name (parameters) | ||
``` | ||
|
||
##### How to define a FunctionHow to define a Function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we follow the same pattern as you started in C? We stopped at number 8 in this readme 'Functions'.
While is also used to iterate a set of statements based on a condition. Usually while is preferred when number of iterations are not known in advance. | ||
|
||
````python | ||
while condition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing colon ':'
|
||
````python | ||
myset{"iPhone","Pixel","Samsung"} | ||
print{myset} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use parenthesis: print(myset)
Set is a collection which is unordered and unindexed. Sets are specified in curly brackets. | ||
|
||
````python | ||
myset{"iPhone","Pixel","Samsung"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be myset = {"iPhone", "Pixel", "Samsung"}
##### Switch: | ||
Switch is used to replace nested If-Else statements. | ||
```js | ||
switch(condition){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The breaks are written within square brackets '[]' Can we please remove these square brackets?
````java | ||
public class Greeting { | ||
static void hello() { | ||
System.out.println("Hello.. Happy learning!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this '..' intended?
Description of changes
Adding a few elixir scripts
Added elixir logo
Updated README.md
Added language specific readme docs