Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder colour fix #525

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Conversation

s1-ranjan
Copy link

Description

In this PR I am pushing Pink and Violet folder icons, which I find to be not properly mapped.

@keeferrourke
Copy link
Owner

Please remove the unrelated Mathematic icons from this PR.

@s1-ranjan
Copy link
Author

@keeferrourke will it not impact my previous contribution for the Mathematica icon?

@keeferrourke
Copy link
Owner

@s1-ranjan it will not! You can merge many independent changes without affecting others.

@s1-ranjan
Copy link
Author

@keeferrourke Please have a look and let the modification should go for merger.

@keeferrourke
Copy link
Owner

Just needs to be cleaned up, as outlined in the wiki. tidy and svgcleaner are your friends :)

@s1-ranjan
Copy link
Author

s1-ranjan commented Feb 18, 2020

yes both the packages has been executed, from my side

@keeferrourke
Copy link
Owner

I still see inkscape metadata in the diff though 🤔

@s1-ranjan
Copy link
Author

@keeferrourke can you please have a look now

@keeferrourke
Copy link
Owner

Still not good.

@s1-ranjan
Copy link
Author

@keeferrourke what about this icon pair?

@keeferrourke
Copy link
Owner

👌 now just run tidy as indicated here

@keeferrourke
Copy link
Owner

The magenta icon still needs to be cleaned as well.

@s1-ranjan
Copy link
Author

@keeferrourke Magenta?
Does you mean to say violet is ok

@s1-ranjan
Copy link
Author

I was just wondering and struggling with pink and violet icons, what about with other folder colours are they okay?

@s1-ranjan
Copy link
Author

Please have a look now

@s1-ranjan
Copy link
Author

@keeferrourke , may I push a new icon by making a new request?

Copy link
Author

@s1-ranjan s1-ranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modification Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants