feat: Add support for tracing for http addon #1021
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhussain91
force-pushed
the
feature/keda-http-addon-tracing
branch
2 times, most recently
from
f945b23
to
1eb19da
Compare
bhussain91
force-pushed
the
feature/keda-http-addon-tracing
branch
from
f64c6dc
to
480050e
Compare
JorTurFer
reviewed
May 18, 2024
Comment on lines
28
to
31
| - name: KEDA_HTTP_TRACE_ENDPOINT | ||
| value: "opentelemetry-collector.open-telemetry-system:4318" | ||
| - name: KEDA_HTTP_TRACE_INSECURE | ||
| value: "true" |
There was a problem hiding this comment.
I didn't noticed it with the first PR was created, but we should respect the OTEL spec for env vars: https://opentelemetry.io/docs/specs/otel/protocol/exporter/
Could you change the new envs to respect (or use) the SDK envs?
There was a problem hiding this comment.
refactored to using the OTEL SDK envs instead
bhussain91
force-pushed
the
feature/keda-http-addon-tracing
branch
4 times, most recently
from
c95f18e
to
eb64c18
Compare
JorTurFer
reviewed
May 26, 2024
interceptor/config/tracing.go
Outdated
Comment on lines
8
to
13
| type Tracing struct { | ||
| // States whether tracing should be enabled, False by default | ||
| Enabled bool `envconfig:"KEDA_HTTP_TRACING_ENABLED" default:"false"` | ||
| // Sets what tracing export to use, must be one of: console,otlphttp | ||
| Exporter string `envconfig:"KEDA_HTTP_TRACE_EXPORTER" default:"console"` | ||
| } |
There was a problem hiding this comment.
We are going to rename other envs to be aligned with the spec, so we have to change these 2 too
What about
Suggested change
| type Tracing struct { | |
| // States whether tracing should be enabled, False by default | |
| Enabled bool `envconfig:"KEDA_HTTP_TRACING_ENABLED" default:"false"` | |
| // Sets what tracing export to use, must be one of: console,otlphttp | |
| Exporter string `envconfig:"KEDA_HTTP_TRACE_EXPORTER" default:"console"` | |
| } | |
| type Tracing struct { | |
| // States whether tracing should be enabled, False by default | |
| Enabled bool `envconfig:"OTEL_EXPORTER_OTLP_TRACES_ENABLED" default:"false"` | |
| // Sets what tracing export to use, must be one of: console,otlphttp | |
| Exporter string `envconfig:"OTEL_EXPORTER_OTLP_PROTOCOL" default:"console"` | |
| } |
interceptor/tracing/tracing.go
Outdated
| switch strings.ToLower(tCfg.Exporter) { | ||
| case "console": | ||
| return stdouttrace.New() | ||
| case "otlphttp": |
There was a problem hiding this comment.
I think that this should be http/protobuf based on docs: https://opentelemetry.io/docs/specs/otel/protocol/exporter/#specify-protocol
Does it make sense supporting also grpc?
|
@bhussain91 any update on this please? |
Signed-off-by: Bilal Hussain <[email protected]>
bhussain91
force-pushed
the
feature/keda-http-addon-tracing
branch
from
eb64c18
to
b093281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bilal Hussain [email protected]
Provide a description of what has been changed
The change is to add tracing capability into the keda http addon using opentelemetry. The changes allows the add on to generate and export spans to console (development) or otel gRPC endpoint. Further information on how to configure tracing can be found in the docs
Checklist
README.mddocs/directoryFixes #