Improving String concatenation #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String are an immutable object in Java.
Therefore, concatenating Strings via the '+' operator creates a lot of Intermediate garbage Strings.
Specifically, if the Input contains N words in the sentence, then the original solution will generate 2*N intermediate Strings.
For instance, for input "Hello World from github"
The intermediate Strings are: "", "github", "github ", "github from", "github from ", github from World", "github from World ", and the result itself: "github from World Hello".
A better approach would be using the StringBuilder object which does not create intermediate Strings.