Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added command to print complete recipe #136

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Akshit42-hue
Copy link

Signed-off-by: Akshit42-hue [email protected]

Fixes #120

@Akshit42-hue
Copy link
Author

cc @sahil-lakhwani @PrasadG193

@Akshit42-hue
Copy link
Author

Any updates @sahil-lakhwani @PrasadG193 :)

@PrasadG193
Copy link
Member

Thanks for the PR @Akshit42-hue.
Looks like the CI is failing. Could you please try to fix that? Let us know if you need any help

Signed-off-by: Akshit42-hue <[email protected]>
@Akshit42-hue
Copy link
Author

Mergify is still failing. How can I fix it? @PrasadG193

Copy link
Member

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akshit42-hue could you please add a sample output of the command for existing and missing recipe in the PR description?

path := info[0].Path
// fs,e os.OpenFile(path)
data, err := os.ReadFile(path)
check(err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not panic. Rather return and handle err

return "", fmt.Errorf("no recipe found for %s", appName)
}
path := info[0].Path
// fs,e os.OpenFile(path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a subcommand to print complete recipe for an app
2 participants