Update to support 9.3.0 without Cucumber vulnerabilities #163
Conversation
Changed the base image in the Dockerfile from Ubuntu 20.04 to the latest stable version available.
- Changed font package name for Ubuntu installation to match new naming convention.
- Updated Gradle version from 5.4.1 to 7.6.4 in the setup script for installation via download link.
Added commands to add Mozilla Firefox repository key, source, preferences, and updated the package list before installing Firefox in the setup script.
| @@ -1,4 +1,4 @@ | |||
| FROM ubuntu:20.04 | |||
| FROM ubuntu:latest | |||
There was a problem hiding this comment.
The team is using ubuntu 20.04 as base version. So can you rollback to 20.04 to avoid some side effect issue. The team will plan to support latest LTS version later
There was a problem hiding this comment.
It was a mistake for me to switch to latest, but I also think it is a mistake for us to sit on 20.04 at this point. How long do you think before we upgrade to the current LTS?
There was a problem hiding this comment.
@coty thanks for your reminding
https://wiki.ubuntu.com/Releases
Ubuntu 20.04 LTS - End of Standard Support: [April 2025]
We should upgrade to Ubuntu 22.04.4 LTS - End of Standard Support: [June 2027]
|
|
||
| echo "Install Mozilla Firefox" | ||
| install -d -m 0755 /etc/apt/keyrings |
There was a problem hiding this comment.
Can you explain these code? without it, the docker still download correct Firefox version
There was a problem hiding this comment.
Updates Firefox installation to install Firefox rather than just a Span pointer
This might only be relevant with later Ubuntu versions, but in those later versions, apt no longer actually installs Firefox. The change is described here:
|
@HieuBui419 |
This makes several changes to Dockerfile and setup.sh to remove vulnerabilities from the Docker image.