Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] remove retain annotations logic #4940

Conversation

XiShanYongYe-Chang
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

As comments in #4847 (comment), so we can remove the retain annotation corev1.ServiceAccountUIDKey logic for ServiceAccount.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 15, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 15, 2024
@XiShanYongYe-Chang
Copy link
Member Author

/cc @a7i @chaunceyjiang

@karmada-bot karmada-bot requested a review from a7i May 15, 2024 03:11
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.25%. Comparing base (90b4616) to head (581f392).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4940      +/-   ##
==========================================
- Coverage   53.25%   53.25%   -0.01%     
==========================================
  Files         252      252              
  Lines       20514    20507       -7     
==========================================
- Hits        10925    10920       -5     
+ Misses       8866     8865       -1     
+ Partials      723      722       -1     
Flag Coverage Δ
unittests 53.25% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member

Did you test it?

@XiShanYongYe-Chang
Copy link
Member Author

Yes, The function is normal after the test.

Copy link
Contributor

@a7i a7i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

🏆

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@RainbowMango
Copy link
Member

Just a reminder, please check if we still need the uuid, key, value during the test.

createSecret := func(secretType corev1.SecretType, uuid, key, value string) *unstructured.Unstructured {

Please rebase this PR as #4930 (comment)

@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2024
@XiShanYongYe-Chang
Copy link
Member Author

Just a reminder, please check if we still need the uuid, key, value during the test.

Thanks, We don't need to test the uid anymore.

Updated.

cc @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@karmada-bot karmada-bot merged commit b401112 into karmada-io:master May 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants