-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cleanup] remove retain annotations logic #4940
[Cleanup] remove retain annotations logic #4940
Conversation
/cc @a7i @chaunceyjiang |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4940 +/- ##
==========================================
- Coverage 53.25% 53.25% -0.01%
==========================================
Files 252 252
Lines 20514 20507 -7
==========================================
- Hits 10925 10920 -5
+ Misses 8866 8865 -1
+ Partials 723 722 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Did you test it? |
Yes, The function is normal after the test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
🏆
Just a reminder, please check if we still need the
Please rebase this PR as #4930 (comment) |
Signed-off-by: changzhen <[email protected]>
4d2def9
to
581f392
Compare
Thanks, We don't need to test the uid anymore. Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a7i, RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
As comments in #4847 (comment), so we can remove the retain annotation corev1.ServiceAccountUIDKey logic for ServiceAccount.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: