-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add e2e for WorkloadRebalancer #4869
Conversation
b514792
to
a8ec98c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4869 +/- ##
==========================================
+ Coverage 53.19% 53.24% +0.05%
==========================================
Files 252 252
Lines 20509 20514 +5
==========================================
+ Hits 10909 10923 +14
+ Misses 8880 8868 -12
- Partials 720 723 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a8ec98c
to
6d9d11f
Compare
6d9d11f
to
49b4b20
Compare
/hold for #4875 |
7852732
to
385aec2
Compare
Thanks~ |
385aec2
to
b36c25a
Compare
@XiShanYongYe-Chang comments all fixed. |
b36c25a
to
249fe29
Compare
249fe29
to
8405294
Compare
Signed-off-by: chaosi-zju <[email protected]>
8405294
to
9211d27
Compare
comment all fixed, review can going on~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
add e2e for WorkloadRebalancer
Which issue(s) this PR fixes:
Fixes part of #4840
Special notes for your reviewer:
Does this PR introduce a user-facing change?: