Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use updated thymeleaf syntax #2372

Merged
merged 1 commit into from
Jul 30, 2023
Merged

chore: use updated thymeleaf syntax #2372

merged 1 commit into from
Jul 30, 2023

Conversation

dersvenhesse
Copy link
Contributor

@dersvenhesse dersvenhesse commented Jul 30, 2023

Running karate with current thymeleaf versions generates some warnings for karate-feature.html:

[THYMELEAF][main][karate-feature.html] Deprecated unwrapped fragment expression \"karate-posthog.html\" found in template karate-feature.html, line 15, col 15. Please use the complete syntax of fragment expressions instead (\"~{karate-posthog.html}\")
[THYMELEAF][main][karate-feature.html] Deprecated attribute {th:include,data-th-include} found in template karate-feature.html, line 74, col 16. Please use {th:insert,data-th-insert} instead, this deprecated attribute will be removed in future versions of Thymeleaf
[THYMELEAF][main][karate-feature.html] Deprecated unwrapped fragment expression \"karate-leftnav.html\" found in template karate-feature.html, line 31, col 14. Please use the complete syntax of fragment expressions instead (\"~{karate-leftnav.html}\"). The old, unwrapped syntax for fragment expressions will be removed in future versions of Thymeleaf

This PR fixes those by using current syntax, similar to #2368.

  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

@ptrthomas ptrthomas merged commit def127e into karatelabs:develop Jul 30, 2023
1 check passed
@dersvenhesse dersvenhesse changed the title chore: use update thymeleaf syntax chore: use updated thymeleaf syntax Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants