Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Netty HttpPostRequestEncoder with "HTML5" encoder mode to prevent… #2370

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

dovikos
Copy link

@dovikos dovikos commented Jul 26, 2023

… "multipart/mixed" body

Description

  • Relevant Issues : Prevent deprecated multipart/mixed content-type, see this thread
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

@ptrthomas
Copy link
Member

@dovikos okay that referenced thread is good enough context. but can you create a test similar to https://github.com/karatelabs/karate/blob/v1.4.0/karate-core/src/test/java/com/intuit/karate/core/mock/upload.feature or https://github.com/karatelabs/karate/blob/v1.4.0/karate-core/src/test/java/com/intuit/karate/core/KarateMockHandlerTest.java#L352

@ptrthomas ptrthomas merged commit a5d1abb into karatelabs:develop Jul 27, 2023
1 check passed
@ptrthomas
Copy link
Member

much thanks @dovikos - we appreciate the PR 👍

@dovikos dovikos deleted the patch/multipart-request branch July 28, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants