karate 1.4.1- Dynamic property ( set in runner) not overridden from maven command

[rc2201]

Attached is the repo to reproduce the issue.

Details:-

1. dynamic properties karate.username and karate.password are defined in the config with default value.
2. Have dummy values setup in the runner file i.e. ExamplesTest.java.
3. karate version is set to 1.4.1 in attached repo.

Execute below maven command-
mvn test -Dtest=ExamplesTest -Dkarate.username=UsernamefromCmd -Dkarate.password=PasswordfromCmd
check the payload for the API call in summary report. Username and password value is being picked from runner.

4. Change the karate version to 1.4.0 in pom file and run the command from#3 again.

Payload is using correct value of username and password i.e. values passed in the maven command.

Attaching the screenshot showing payload for 1.4 and 1.4.1.

karatePropertyOverride.zip

[ptrthomas]

probably related to #2444 - contributions welcome

[dvargas46]

this appears to be from this change.

if the preference should be the JVM system properties over the ones configured by the builder, then a fix could be to switch back that part of the change in the runner.

[ptrthomas]

@dvargas46 I'm unable to figure this out by reading the code, maybe needs some debugging

[dvargas46]

@ptrthomas just tried debugging it and this does appear to be the issue from what I could tell.

going from

systemProperties.putAll(new HashMap(System.getProperties()));

to this

Map temp = new HashMap(System.getProperties());
temp.putAll(systemProperties); // make sure user-specified takes precedence
systemProperties = temp;

reverses the previous behavior. I.e., now the systemProperties set on the java builder is overwriting any common system properties defined on the jvm (using -D), instead of how it was before.

I think most would expect the jvm props to take precedence, at least from my experience. Let me know and I can put out a small PR to bring back the old behavior here.

[ptrthomas]

@dvargas46 thanks, yes please do proceed with a PR

[ptrthomas]

karate 1.5.0.RC3 including this fix is now available

[rc2201]

I tested this out against 1.5.0RC3 and still seeing the issue.

Changes made to POM in earlier attached project- Updated the karate version and group Id.

<karate.version>1.5.0.RC3</karate.version>
<groupId>io.karatelabs</groupId>

Ran the same command provided earlier and still seeing username and password being picked from runner and not being overridden.

[dvargas46]

Yes, it looks like some changes were made after my PR that brought back the issue.

@ptrthomas , I can create another PR that should fix the core issue here while retaining the new changes made. Or would you prefer to wait until after 1.5.0 is released?

[ptrthomas]

@dvargas46 thanks, apologies since I may have broken it with some other changes to the runner / suite part.

please go ahead with another PR, there will be at least one more RC release of 1.5.0 before final