property override fix karatelabs#2474

dvargas46 · Feb 16, 2024 · c156764 · c156764
1 parent 9087fdc
commit c156764
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/karate-core/src/main/java/com/intuit/karate/Runner.java b/karate-core/src/main/java/com/intuit/karate/Runner.java
@@ -288,7 +288,6 @@ public T systemProperty(String key, String value) {
  if (systemProperties == null) {
  systemProperties = new HashMap();
  }
- System.setProperty(key, value);
  systemProperties.put(key, value);
  return (T) this;
  }

diff --git a/karate-core/src/test/java/com/intuit/karate/SystemPropertiesTest.java b/karate-core/src/test/java/com/intuit/karate/SystemPropertiesTest.java
@@ -21,6 +21,8 @@ void testSystemPropertiesSetOnRunner() {
  builder.resolveAll();
  String propertyValue = builder.systemProperties.get(TEST_PROP);
  assertEquals(propertyValue, "setOnRunner");
+ String jvmValue = System.getProperty(TEST_PROP);
+ assertEquals(jvmValue, null);
  }
 
  @Test
@@ -30,6 +32,8 @@ void testSystemPropertiesSetOnJVM() {
  builder.resolveAll();
  String propertyValue = builder.systemProperties.get(TEST_PROP);
  assertEquals(propertyValue, "setOnJVM");
+ String jvmValue = System.getProperty(TEST_PROP);
+ assertEquals(jvmValue, "setOnJVM");
  }
 
  @Test
@@ -38,9 +42,9 @@ void testPrecedenceOfSystemPropertiesSetOnRunnerAndJVM() {
  Builder<?> builder = Runner.builder().systemProperty(TEST_PROP, "setOnRunner");
  builder.resolveAll();
  String propertyValue = builder.systemProperties.get(TEST_PROP); 
- assertEquals(propertyValue, "setOnRunner");
+ assertEquals(propertyValue, "setOnJVM");
  String jvmValue = System.getProperty(TEST_PROP);
- assertEquals(jvmValue, "setOnRunner");
+ assertEquals(jvmValue, "setOnJVM");
  }
 
 }