Skip to content

Commit

Permalink
revert some changes that broke karate-core jar
Browse files Browse the repository at this point in the history
the classifier all works but using the core jar causes class not found errors
suspect the maven shade plugin upgrade to be the culprit
  • Loading branch information
ptrthomas committed Jul 3, 2023
1 parent c668a39 commit afed9af
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion karate-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
<dependency>
<groupId>com.linecorp.armeria</groupId>
<artifactId>armeria</artifactId>
<version>1.24.1</version>
<version>1.23.1</version>
</dependency>
<dependency>
<groupId>org.apache.httpcomponents</groupId>
Expand Down
4 changes: 1 addition & 3 deletions karate-e2e-tests/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@
<groupId>com.intuit.karate</groupId>
<artifactId>karate-core</artifactId>
<version>${project.version}</version>
<scope>test</scope>
<!-- next line is normally not required, but is here for testing karate release process -->
<classifier>all</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<java.version>11</java.version>
<maven.compiler.version>3.11.0</maven.compiler.version>
<maven.surefire.version>3.0.0</maven.surefire.version>
<maven.shade.version>3.5.0</maven.shade.version>
<maven.shade.version>3.2.4</maven.shade.version>
<junit5.version>5.9.3</junit5.version>
<nexus.staging.plugin.version>1.6.13</nexus.staging.plugin.version>
<spring.version>5.3.19</spring.version>
Expand Down

0 comments on commit afed9af

Please sign in to comment.