use nio for some operations

karatelabs · Jul 20, 2023 · 220acd1 · 220acd1
1 parent 334e689
commit 220acd1
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/karate-core/src/main/java/com/intuit/karate/job/JobUtils.java b/karate-core/src/main/java/com/intuit/karate/job/JobUtils.java
@@ -27,6 +27,8 @@
 import java.io.FileInputStream;
 import java.io.FileOutputStream;
 import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.nio.channels.FileChannel;
 import java.util.function.Predicate;
 import java.util.zip.ZipEntry;
 import java.util.zip.ZipInputStream;
@@ -76,10 +78,15 @@ private static void zip(File fileToZip, String fileName, ZipOutputStream zipOut,
  ZipEntry zipEntry = new ZipEntry(fileName);
  zipOut.putNextEntry(zipEntry);
  FileInputStream fis = new FileInputStream(fileToZip);
- byte[] bytes = new byte[1024];
- int length;
- while ((length = fis.read(bytes)) >= 0) {
- zipOut.write(bytes, 0, length);
+ FileChannel fc = fis.getChannel();
+ int bufferSize = 1024;
+ if (bufferSize > fc.size()) {
+ bufferSize = (int) fc.size();
+ }
+ ByteBuffer bb = ByteBuffer.allocate(bufferSize);
+ while (fc.read(bb) > 0) {
+ zipOut.write(bb.array(), 0, bb.position());
+ bb.clear();
  }
  fis.close();
  }