New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: check if i_to_b32 is needed or not #93

Closed

iamhardikat11 wants to merge 1 commit into karask:master from iamhardikat11:master

Contributor

iamhardikat11 commented Apr 21, 2024

In the utils.py that was minor change done to remove i_to_b32 and I changed the i_to_b function to remove redundancy.
All Tests Passed.


TODO: check if i_to_b32 is needed or not

2976c61

Owner

karask commented Apr 22, 2024

The current TODO file does not contain this todo. The i_to_b32 is mostly used so I want to keep it (and call this in the code).

The i_to_h should stay even if it is in comments.

Your update to i_to_b is fine but it shouldn't used for b32 cases. In case byte_length is None you unnecessarily have a print statement.

karask closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment