Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dev-wallet): split keyset and account model #2162

Merged
merged 3 commits into from
May 31, 2024

Conversation

javadkh2
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
alpha-docs ❌ Failed (Inspect) 💬 Add feedback May 31, 2024 10:23am
dev-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 10:23am
kadena-js-marmalade-marketplace ❌ Failed (Inspect) May 31, 2024 10:23am
proof-of-us ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 10:23am
tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 10:23am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
marmalade-marketplace ⬜️ Ignored (Inspect) Visit Preview May 31, 2024 10:23am
react-ui ⬜️ Ignored (Inspect) Visit Preview May 31, 2024 10:23am

Copy link

changeset-bot bot commented May 21, 2024

⚠️ No Changeset found

Latest commit: d6e58d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -49,7 +49,7 @@ const createConnectionPool = (
};

const DB_NAME = 'dev-wallet';
const DB_VERSION = 28;
const DB_VERSION = 31;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general, as long as this number is different it will rebuild right? regardless of the number

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the version is less than the current db version then it throws an error but if its bigger than that it runs the migrate code which for now it just wipe the database ad create a fresh one (later we must address this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants