Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update on-pr-submit and dependents #1065

Draft
wants to merge 4 commits into
base: devel
Choose a base branch
from
Draft

Conversation

leelavg
Copy link
Collaborator

@leelavg leelavg commented May 3, 2024

Started work to only change Minikube Version and be done with it, however had to do these many changes as for Minikube to work we need to install extra tools due to deprecation of docker shim.

Only touched PR Submit workflows and may modify renaming in later PRs.

Changes:

  1. Remove deprecated usage of save-ouput GH flow and use GITHUB_OUPUT
  2. Use native cache from setup-python action rather than custom step
  3. Remove minikube as we were testing against 3 year old kubernetes version (1.20) and replace minikube with k3d, bump kube version
  4. Consolidate tests into a single file, a couple of years back main test file was refactored and as yearly maintainence except main test the environment is updated as we don't want to debug both tests & env failures at once
  5. Since local docker is being used as pass through registry adding new steps to save and restore docker image cache

@leelavg
Copy link
Collaborator Author

leelavg commented May 3, 2024

can look at https://github.com/leelavg/kadalu/blob/update-ci/tests/tests.sh for a clean file w/o changes.

@leelavg leelavg force-pushed the update-ci branch 6 times, most recently from b7d9a05 to 2f0be38 Compare May 3, 2024 12:29
@leelavg leelavg marked this pull request as draft May 3, 2024 12:39
@leelavg leelavg force-pushed the update-ci branch 2 times, most recently from 83f696c to fe626ba Compare May 3, 2024 12:49
Started work to only change Minikube Version and be done with it, however
had to do these many changes as for Minikube to work we need to install
extra tools due to deprecation of docker shim.

Only touched PR Submit workflows and may modify renaming in later PRs.

Changes:
1. Remove deprecated usage of save-ouput GH flow and use GITHUB_OUPUT
2. Use native cache from setup-python action rather than custom step
3. Remove minikube as we were testing against 3 year old kubernetes
version (1.20) and replace minikube with k3d, bump kube version
4. Consolidate tests into a single file, a couple of years back main
test file was refactored and as yearly maintainence except main test the
environment is updated as we don't want to debug both tests & env failures
at once
5. Since local docker is being used as pass through registry adding new
steps to save and restore docker image cache

Signed-off-by: Leela Venkaiah G <[email protected]>
Signed-off-by: Leela Venkaiah G <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant