Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of custom example #1280

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AbhijithGanesh
Copy link

@AbhijithGanesh AbhijithGanesh commented Feb 1, 2022

Signed-off-by: Abhijith Ganesh [email protected]

What this PR does:
Adds an example of a custom chart

Which issue(s) this PR fixes:
Fixes #1279

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

Signed-off-by: Abhijith Ganesh <[email protected]>
@AbhijithGanesh AbhijithGanesh requested a review from a team as a code owner February 1, 2022 08:03
@burmanm
Copy link
Contributor

burmanm commented Feb 1, 2022

Hi,

I think something went wrong with this PR. There are 419 files in the commit and some of them don't look like belonging to this PR. Could you check and only commit files that are relevant?

@AbhijithGanesh
Copy link
Author

Hi,
I do agree but I am not aware of methods to add charts to GitHub without adding these files, Can you suggest any alternative

@burmanm
Copy link
Contributor

burmanm commented Feb 1, 2022

Only add a single file each time git add <file> instead of adding a whole working directory.

@AbhijithGanesh
Copy link
Author

Yeah but the example is for a custom chart, I have to add all these files, how else can I make a custom chart?

@burmanm
Copy link
Contributor

burmanm commented Feb 1, 2022

You should not add unmodified files, such as dependency source code. Those should not be part of the chart (they're not part of k8ssandra/k8ssandra either)

@AbhijithGanesh
Copy link
Author

Got it, will make the changes and push. Thanks for the clarification

@AbhijithGanesh
Copy link
Author

@burmanm I have made changes and it reduced to the YAML template files, they don't come as a part of the dependency(as far as I know), should they be there or should something be done about them?

@jdonenine
Copy link
Contributor

I was thinking that what we would get here is just an example values.yaml that provides for a certain type of configuration you wanted to exhibit?

Is there a reason we want anything more than that?

@AbhijithGanesh
Copy link
Author

Well, the chart would need .helmignore, chart.yaml and values.yaml mandatorily. Other template files maybe removed but I am not sure about the effects it may have once we delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K8SSAND-1202 ⁃ Provide examples of custom chart configurations
3 participants