Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish originals and copies for replicated secrets #1192

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Miles-Garnsey
Copy link
Member

Replicated secrets controller adds an annotation noting that the secret was create through replication.

Which issue(s) this PR fixes:
Fixes #1191

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@Miles-Garnsey Miles-Garnsey requested a review from a team as a code owner January 30, 2024 03:05
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

5.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Miles-Garnsey Miles-Garnsey marked this pull request as draft February 6, 2024 07:19
@Miles-Garnsey
Copy link
Member Author

I am blocked on this. For some reason in the envtests I keep getting a combination of context cancelled and error re-reading certificate {"error": "open /var/folders/_n/g9shgcsj00d68_t011c77v_h0000gn/T/envtest-serving-certs-1964668802/tls.key: no such file or directory"} [sigs.k8s.io/controller-runtime/pkg/certwatcher.(*CertWatcher).handleEvent](http://sigs.k8s.io/controller-runtime/pkg/certwatcher.(*CertWatcher).handleEvent) errors.

I don't know how to interpret these right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotation for replicated secrets to make them distinguishable from originals
1 participant