Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeSelector support to crd-upgrader-job-k8ssandra #1079

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rexbut
Copy link

@rexbut rexbut commented Oct 4, 2023

What this PR does:
This PR adds support for the nodeSelector variable in the crd-upgrader-job-k8ssandra job. This feature allows users to specify which nodes this job can run on, providing a workaround for the ARM64 compatibility issue with the k8ssandra/k8ssandra-tools container.

Which issue(s) this PR fixes:
Fixes #1078

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@rexbut rexbut requested a review from a team as a code owner October 4, 2023 09:11
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adejanovski
Copy link
Contributor

Hi @rexbut,

thanks a lot for sending this PR!
Do you think we would still need this change if we built an arm64 version of the k8ssandra-tools image?
It should be pretty easy to do and is probably the last image we ship that doesn't have arm builds yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nodeSelector support to crd-upgrader-job-k8ssandra
2 participants