Upgrade canary test to fully update the cluster after the canary upgrade #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmanm
force-pushed
the
canary_test_upgrade
branch
from
ae7f0b4
to
a1171e3
Compare
This was referenced May 16, 2024
…n the hash calculation. Move generation update at the end of the reconcile, ignoring state change
burmanm
force-pushed
the
canary_test_upgrade
branch
from
a92de20
to
3d146e5
Compare
adejanovski
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Tests that after the canary upgrade, we can fully upgrade the cluster to the state we wanted. This means, first running a canary upgrade to test that the new version works and then update the rest.
Which issue(s) this PR fixes:
Fixes #656
Fixes #657
Fixes #382
Checklist