Add scalable functions (SF) support #310
Conversation
This patch adds support for scalable functions (https://docs.nvidia.com/networking/display/bluefielddpuosv385/scalable+functions). They are represented on the host as auxiliary devices. In order to for the minimal codebase changes, this patch updated the sriovnet dependency, which already has support for SFs, together with its needed dependencies. This patch also adds architecture detection to the Makefile. Signed-off-by: Alin Gabriel Serdean <[email protected]>
kubevirt-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: naserdean The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
needs-ok-to-test
|
Hi @naserdean. Thanks for your PR. I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| } | ||
|
|
||
| // IsAuxDeviceName check if passed device id is a Auxiliary device name | ||
| func IsAuxDeviceName(deviceID string) bool { |
There was a problem hiding this comment.
it might be safer to check if given device is found on the auxiliary bus like in [1]
the regex is quite loose for SFs
[1] https://github.com/containernetworking/plugins/pull/1003/files
| @@ -13,7 +13,12 @@ export GOROOT=$(BIN_DIR)/go/ | |||
| export GOBIN = $(GOROOT)/bin/ | |||
| export PATH := $(GOBIN):$(PATH):$(BIN_DIR) | |||
| GOPATH = $(CURDIR)/.gopath | |||
| GOARCH ?= amd64 | |||
| UNAME=$(shell uname -m | tr '[:upper:]' '[:lower:]') | |||
There was a problem hiding this comment.
this should go in a separate PR ?
There was a problem hiding this comment.
oops,
indeed, will drop the change from this pr and create a new one just for this
| if err != nil { | ||
| return "", err | ||
| } | ||
|
|
||
| return rep, nil | ||
| } | ||
|
|
||
| // SetupSriovInterface moves smartVF into container namespace, rename it with ifName and also returns host interface with VF's representor device | ||
| func SetupSriovInterface(contNetns ns.NetNS, containerID, ifName string, mtu int, deviceID string) (*current.Interface, *current.Interface, error) { |
There was a problem hiding this comment.
should we rename this method as it now handles both sr-iov and auxiliary devices ?
|
Thanks for the contribution @naserdean! CC @SchSeba |
kubevirt-bot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This patch adds support for scalable functions
(https://docs.nvidia.com/networking/display/bluefielddpuosv385/scalable+functions).
They are represented on the host as auxiliary devices.
In order to for the minimal codebase changes, this patch updated the sriovnet dependency,
which already has support for SFs, together with its needed dependencies.
This patch also adds architecture detection to the Makefile.
What this PR does / why we need it:
Add support for auxiliary devices.
Special notes for your reviewer:
First time I contribute to ovs-cni.
Apologies up front for any headaches 馃槃 .
Release note: