Configuration writes should be atomic #1252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a method `atomicFileWrite(...)` which writes to a temporary file and then renames it to avoid partial reads, e.g. ``` Mar 29 04:13:05 labkubedualhost-node-1 crio[33593]: time="2024-03-29 04:13:05.977398607+09:00" level=info msg="CNI monitoring event CREATE \"/etc/cni/net.d/00-multus.conf\"" Mar 29 04:13:05 labkubedualhost-node-1 crio[33593]: time="2024-03-29 04:13:05.977767189+09:00" level=error msg="Error loading CNI config file /etc/cni/net.d/00-multus.conf: error parsing configuration: unexpected end of JSON input" ```
dougbtv
force-pushed
the
thick-atomic-config-write
branch
from
ad5970c
to
5d0ff07
Compare
s1061123
requested changes
Apr 1, 2024
| @@ -64,6 +65,32 @@ func NewManager(config MultusConf) (*Manager, error) { | |||
| return newManager(config, defaultPluginName) | |||
| } | |||
|
|
|||
| // atomicFileWrite writes our configs atomically to avoid partial reads | |||
| func atomicFileWrite(filename string, data []byte, perm os.FileMode) error { | |||
There was a problem hiding this comment.
As warning mentiond, perm is not used in the function hence, none changed the files permission to 0644. Could you please change the file permission?
| func atomicFileWrite(filename string, data []byte, perm os.FileMode) error { | ||
| // Create a temporary file in the same directory as the destination file | ||
| dir := filepath.Dir(filename) | ||
| tmpFile, err := ioutil.TempFile(dir, ".multus.tmp") |
There was a problem hiding this comment.
ioutil.TempFile() is deprecated as https://pkg.go.dev/io/ioutil#TempFile so please change that.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a method
atomicFileWrite(...)which writes to a temporary file and then renames it to avoid partial reads, e.g.