feat: propagate the err message from getNetDelegate #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
propagate the err message from getNetDelegate, and log the error in the error message, we don't want to lose the err here
|
@s1061123 Hi, would you like to have a look at this PR? |
dougbtv
approved these changes
Jan 4, 2024
|
Thanks for your contribution! |
|
@dougbtv Hi thanks for the reply, but sorry I don't get your point, what do you mean by an example? And how can I able to access the inner error if I don't propagate the err? What can I do with yaml? |
|
@xujihui1985 sorry! I had made a comment by accident on the wrong pull request! |
|
Hi, would anyone like to merge this PR? the failing test should have no relation with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
propagate the err message from getNetDelegate, and log the error in the error message, we don't want to lose the err here