This repository has been archived by the owner on Aug 22, 2022. It is now read-only.
[ser2sock] use a headless service #1707
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since these generally talk to individual instances of physical hardware, it is unlikely that a user intends load balancing of multiple instances to multiple devices. Using a headless service (`clusterIP: None`) removes the k8s load balancer and allows clients to talk directly to the ser2sock pod via the service name.
ghost
added
size/XS
disconn3ct
requested review from
onedr0p,
bjw-s,
billimek,
carpenike and
truxnell
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Default to a headless service for ser2sock instead of a clusterIP load balancer
Benefits
Since these generally talk to individual instances of physical hardware, it is unlikely that a user intends load balancing of multiple instances to multiple devices. Using a headless service (
clusterIP: None) removes the k8s load balancer and allows clients to talk directly to the ser2sock pod via the service name.Possible drawbacks
Users who rely on the clusterIP load balancer will need to add
service.main.clusterIP:(no value) to return to the old behavior.Applicable issues
Additional information
Checklist
[home-assistant])Chart.yamlaccording to semver.artifacthub.io/changeschangelog annotation has been updated inChart.yaml. See Artifact Hub documentation for more info.values.yamlfile.