Update mode.py to warn in Mode.FUNCTIONS
access vs. in __new__
#678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, any import of
instructor
raises aDeprecationWarning
. This is noisy and also makes it impossible to have test suites raise an error onDeprecationWarning
. Example code:Summary:
This PR moves the deprecation warning for
FUNCTIONS
inMode
class to only trigger when accessed, reducing import-time noise.Key points:
DeprecationWarning
forFUNCTIONS
from__new__
to__getattribute__
in aMode
metaclass.DeprecationWarning
in test suites.Generated with ❤️ by ellipsis.dev
Summary:
This PR moves the deprecation warning for
FUNCTIONS
in theMode
class to only trigger when accessed, reducing import-time noise.Key points:
DeprecationWarning
forFUNCTIONS
from__new__
to__getattribute__
inMode
class using_WarnOnFunctionsAccessEnumMeta
metaclass.DeprecationWarning
in test suites.Generated with ❤️ by ellipsis.dev