Run Python tests on MacOS with Python 12, replace canvas with jest-canvas-mock
#16314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
krassowski
changed the title
canvas with jest-canvas-mock
|
It looks like vega5 needs it to. Should we just add it to @jupyterlab/testing package or is there value in only having this in individual packages? |
|
@ericsnekbytes you may want to try out this branch - it is passing on CI already |
|
@krassowski Just built this locally and it worked :) Thanks for your work on this! |
|
Great! Can you tick the "Approve" on GitHub review just so that it does not show up as unreviewed later? |
ericsnekbytes
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
canvaswithjest-canvas-mockto fix Error during build steps on macos #16311 by getting rid of the compilation requirementCode changes
None
User-facing changes
None
Backwards-incompatible changes
None