Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow RegExp in galata helper when looking for a tab #16302

Merged
merged 2 commits into from May 13, 2024

Conversation

brichet
Copy link
Contributor

@brichet brichet commented May 7, 2024

Using the galata helper function activity -> getTabLocator doesn't look for the exact string name, and can fail due to duplicate string.

For example it is not possible to use it with the tab Settings, it lead to 2 locators, (1) the expected panel's tab and (2) the settings named Settings Editor Form UI (because the plugin list entry also have a 'tab' role)

Allowing also RegExp can help specifying the expected match string.

References

None

Code changes

Allow string or RegExp (instead of only string) in the activity function that look for a tab name.

User-facing changes

None

Backwards-incompatible changes

None

Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski krassowski added this to the 4.3.0 milestone May 8, 2024
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @brichet!

@brichet brichet merged commit 82f0327 into jupyterlab:main May 13, 2024
81 checks passed
@brichet brichet deleted the galata_activateTab branch May 13, 2024 14:30
@krassowski
Copy link
Member

We will need to branch out 4.2.x from the previous commit (and update configs). I can do that later today or tomorrow.

@brichet
Copy link
Contributor Author

brichet commented May 13, 2024

Sorry for this, I'll be more careful next time.

@brichet
Copy link
Contributor Author

brichet commented May 13, 2024

We will need to branch out 4.2.x from the previous commit (and update configs). I can do that later today or tomorrow.

Out of curiosity, what are the configs to update ? I think of adding a 4.2.x milestone. Is there something else ?
BTW thanks for fixing it already @krassowski.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants