Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advertise the color scheme based on the theme #16301

Merged
merged 1 commit into from May 14, 2024
Merged

Advertise the color scheme based on the theme #16301

merged 1 commit into from May 14, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented May 7, 2024 •
edited

References

Closes #16299

Code changes

Set color-scheme style on <body> to dark if the current theme is dark, and to light if the current theme is light.

User-facing changes

  • Scrollbars and other UI elements (not styled by JupyterLab) in dark mode will use the system dark theme if available
  • SVG icons for kernels which include prefers-color-scheme directive will correctly render with high contrast in dark theme

With "Theme Scrollbars" option disabled (default):

Before After
Screenshot from 2024-05-07 14-45-26 Screenshot from 2024-05-07 14-45-00

Backwards-incompatible changes

None

@jupyterlab-probot jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski krassowski added this to the 4.3.0 milestone May 8, 2024
@jtpio jtpio mentioned this pull request May 14, 2024
Open
jtpio
jtpio approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krassowski krassowski merged commit 4545de3 into jupyterlab:main May 14, 2024
82 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

@fcollonval fcollonval fcollonval approved these changes

Assignees

@krassowski krassowski

Labels
enhancement pkg:apputils
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

Icon classes (like jp-icon0) do not work in launcher tabs for kernels
3 participants
@krassowski @jtpio @fcollonval