Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let FROM <base_image> in the Dockerfile template be configurable #909

Merged
merged 34 commits into from
Jun 9, 2023
Merged

Let FROM <base_image> in the Dockerfile template be configurable #909

merged 34 commits into from
Jun 9, 2023
+159 −62

Commits on Dec 10, 2022

  1. Set ubuntu 20.04 as new base image 

    We would at some point need to set this as the default.
To prepare for that, I think we should make this an option
that is available, and run our tests on this too.

The R stack seems possibly currently unavailable for 20.04
(see https://community.rstudio.com/t/rstudio-server-ubuntu-20-04/64188)
but I'll try it out
    @yuvipanda
    yuvipanda committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    592ccb7 View commit details
    Browse the repository at this point in the history

  2. Switch RSPM to use focal, not bionic

    @yuvipanda
    yuvipanda committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    b724c02 View commit details
    Browse the repository at this point in the history

  3. Don't hardcode ubuntu codename when getting r packages

    @yuvipanda
    yuvipanda committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    8086937 View commit details
    Browse the repository at this point in the history

  4. Make base_image configurable 

    Fixes jupyterhub#487
    @yuvipanda
    yuvipanda committed Dec 10, 2022
    1 Configuration menu
    Copy the full SHA
    20b0815 View commit details
    Browse the repository at this point in the history

  5. Set base image for default buildpack too

    @yuvipanda
    yuvipanda committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    f35a948 View commit details
    Browse the repository at this point in the history

  6. Add test fixture for setting base image

    @yuvipanda
    yuvipanda committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    446e678 View commit details
    Browse the repository at this point in the history

  7. Remove accidental import vscode inserted

    @yuvipanda
    yuvipanda committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    9ff14c1 View commit details
    Browse the repository at this point in the history

  8. Fix rspm test for VERSION_CODENAME

    @yuvipanda
    yuvipanda committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    b58fd15 View commit details
    Browse the repository at this point in the history

  9. Set base_image in a few more places

    @yuvipanda
    yuvipanda committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    7eb143e View commit details
    Browse the repository at this point in the history

  10. Fix typo 

    Co-authored-by: Simon Li <[email protected]>
    @yuvipanda @manics
    yuvipanda and manics committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    c21374d View commit details
    Browse the repository at this point in the history

  11. Use full image tag 

    Fixes jupyterhub#1146

Co-authored-by: Simon Li <[email protected]>
    @yuvipanda @manics
    yuvipanda and manics committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    f776d8e View commit details
    Browse the repository at this point in the history

  12. Add note about what base images are supported

    @yuvipanda
    yuvipanda committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    4d83abc View commit details
    Browse the repository at this point in the history

  13. Added missing base_image argument

    @kardasbart @yuvipanda
    kardasbart authored and yuvipanda committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    389334a View commit details
    Browse the repository at this point in the history

  14. Add setuptools to built image 

    hg-evolve seems to need it, as otherwise it is failing
with:

16 4.520   Downloading hg-evolve-10.5.3.tar.gz (847 kB)
    @yuvipanda
    yuvipanda committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    90c375c View commit details
    Browse the repository at this point in the history

  15. Try using py3-pip when installing in Alpine 

    Seems to be perhaps different than py-pip
    @yuvipanda
    yuvipanda committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    aae6a71 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2022

  1. Readded setuptools

    @kardasbart
    kardasbart committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    8a359f9 View commit details
    Browse the repository at this point in the history

  2. Fixd shell command for buildpacks/r

    @kardasbart
    kardasbart committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    c3d2575 View commit details
    Browse the repository at this point in the history

  3. Added setuptools

    @kardasbart
    kardasbart committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    76731c8 View commit details
    Browse the repository at this point in the history

  4. Bump linux alpine to 3.17 due to setuptools bug

    @kardasbart
    kardasbart committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    21ad4ca View commit details
    Browse the repository at this point in the history

  5. Renamed branch to main

    @kardasbart
    kardasbart committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    52e8076 View commit details
    Browse the repository at this point in the history

  6. Refactored R command

    @kardasbart
    kardasbart committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    b85df8f View commit details
    Browse the repository at this point in the history

  7. Updated master/main branches error info

    @kardasbart
    kardasbart committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    0b9154a View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. Merge pull request #6 from kardasbart/feat/new-base 

    Tests fix
    @yuvipanda
    yuvipanda committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    2b17eca View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Document base image

    @choldgraf
    choldgraf committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    5e75258 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    4eaf096 View commit details
    Browse the repository at this point in the history

  3. Add note on reproducibility

    @choldgraf
    choldgraf committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    4a5ff3c View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    e956501 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2023

  1. Merge branch 'main' into feat/new-base

    @yuvipanda
    yuvipanda committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    99125ab View commit details
    Browse the repository at this point in the history

  2. Support installing RStudio on distros without openssl1.1

    @yuvipanda
    yuvipanda committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    0a3846f View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    01c142b View commit details
    Browse the repository at this point in the history

  4. Fix mismatched quotes

    @yuvipanda
    yuvipanda committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    a6ccf81 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Install libssl-dev unconditionally for R

    @yuvipanda
    yuvipanda committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    f848c81 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into feat/new-base

    @yuvipanda
    yuvipanda committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    5894f63 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Merge branch 'main' into feat/new-base

    @minrk
    minrk committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    e1051c3 View commit details
    Browse the repository at this point in the history