add config to /hub/info endpoint #4442
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds JupyterHub.api_include_config list for selecting which config should be included
sgaist
approved these changes
Jan 19, 2024
Comment on lines
+70
to
+77
| for f in trait_filters: | ||
| if "." not in f: | ||
| full_class_filters.add(f) | ||
| else: | ||
| cls_name, _, trait_name = f.partition(".") | ||
| if cls_name not in full_class_filters: | ||
| cls_filters = class_trait_filters.setdefault(cls_name, set()) | ||
| cls_filters.add(trait_name) |
There was a problem hiding this comment.
Nitpick: single letter variable. I would just use filter
| all_classes = full_class_filters | set(class_trait_filters.keys()) | ||
|
|
||
| # track any sections we didn't look at via instances | ||
| unused_sections = set() | all_classes |
There was a problem hiding this comment.
Isn't all_classes guaranteed to be a set ?
full_class_filters is one even if empty and if so, all_classes is a set of class_trait_filters.keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
JupyterHub.api_include_configlist for selecting which config should be included, which includes nothing by default.instead of adding a new
/api/configendpoint, I elected to add a field to the existing/api/infoendpoint, which already tells things about the Hub, and config seems like it fits with what's already there.Key issues:
closes #4406
WDYT @yuvipanda?