Add configurable choice of a JupyterLab launcher category to present registered proxies (Notebook, Console, Other) #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The launcher category under which the launcher appear can be configured in settings. Default is "Notebook"
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
Issues:
|
Does not seem to work with the original version.
eddienko
force-pushed
the
configure_category
branch
from
e48a84e
to
a896e40
Compare
consideRatio
changed the title
|
A variant of this was merged in #453 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As preparation work for #145 this pull request adds the capability to configure under which launcher category the proxy applications will appear.
It needs a bit of check from people who have more experience with extensions.
Screenshots follow.