Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python 3.12 #2072

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Upgrade to Python 3.12 #2072

wants to merge 4 commits into from

Conversation

max-muoto
Copy link

Describe your changes

Upgrade base image to 3.12

@max-muoto
Copy link
Author

Haven't tested this yet, but it would be nice if we could start looking at moving the base image to being 3.12.

.readthedocs.yaml Outdated Show resolved Hide resolved
@mathbunnyru
Copy link
Member

It seems we depend on this PR: conda-forge/pycurl-feedstock#27

@mathbunnyru mathbunnyru marked this pull request as draft January 7, 2024 09:39
@mathbunnyru
Copy link
Member

Waiting for the upstream packages to be fixed.
@max-muoto if you want to move our docker stacks to Python 3.12 faster, please, consider helping conda-forge contributors by sending PRs to update packages.

I marked this as a draft and subscribed to the relevant PR, will re-run, when the issue resolves.

@consideRatio
Copy link
Collaborator

Issue for pycurl resolved upstream!

@mathbunnyru
Copy link
Member

@consideRatio thanks!

@max-muoto could you please resolve conflicts? Unfortunately, GitHub is not able to do it in the web browser.

@mathbunnyru
Copy link
Member

Something is wrong, as the change should have stayed small, just a few lines of code.

@max-muoto
Copy link
Author

Something is wrong, as the change should have stayed small, just a few lines of code.

Currently rebasing, should be fixed soon.

@max-muoto max-muoto force-pushed the python-3.12 branch 3 times, most recently from 2455425 to 9035f65 Compare March 10, 2024 17:06
@max-muoto max-muoto marked this pull request as ready for review March 10, 2024 17:06
@max-muoto
Copy link
Author

Something is wrong, as the change should have stayed small, just a few lines of code.

Should be good to take a look at now.

@max-muoto
Copy link
Author

Seems we also need to upgrade Pandas, just went ahead and did that.

@@ -63,7 +63,7 @@ USER ${NB_UID}
RUN mamba install --yes \
'grpcio-status' \
'grpcio' \
'pandas=2.0.3' \
'pandas=2.2.1' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked the comment above to make sure you’re using the proper version?

Copy link
Author

@max-muoto max-muoto Mar 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They have pandas<=2.2.1 so we should be good here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to check the latest stable tag, not the current main branch.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry there. Looks like we'll need for their next release, as this commit isn't included in the latest stable tag: ericm-db/spark@98ca3ea

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need to wait on this as well, since we need at least Pandas 2.1.1 to ensure compatibility with 3.12.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjornjorgensen could you please tell us when the Spark release will include this commit? (at least approximately)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.. well we are waiting for hadoop 3.4.0 and a new hive release. We haven't started any RC release yet. I build and test my own jupyterlab https://github.com/bjornjorgensen/jupyter-spark-master-docker and I did try python 3.12 but it breake so match so I'm using python 3.11 as debian testing are using.
And Spark 3.5.1 don't support python 3.12 have a look at apache/spark#43922

@bjornjorgensen
Copy link
Contributor

python 3.10 was released Oct 04, 2021 we updated it #1711 May 28, 2022
python 3.11 was released Oct 24, 2022 we updated it #1844 May 31, 2023
I'm using Manjaro unstable and even here it's Python 3.11.8

@bjornjorgensen
Copy link
Contributor

[VOTE] Release Plan for Apache Spark 4.0.0 (June 2024)

Apache Spark 4.0.0 Release Plan

  1. After creating branch-3.5, set "4.0.0-SNAPSHOT" in master branch.

  2. Creating branch-4.0 on April 1st, 2024.

  3. Apache Spark 4.0.0 RC1 on May 1st, 2024.

  4. Apache Spark 4.0.0 Release in June, 2024.

@bjornjorgensen
Copy link
Contributor

there will be a test soon Re: [DISCUSS] Spark 4.0.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants