Use app's HTTP settings, handle feature settings race condition, CI/build updates, lazy server discovery #882

bollwyvl · 2022-12-10T22:21:41Z

References

supersedes Use app http settings for status, WebSockets #881
fixes Use the host application's server connection settings #880
progress on Slow startup on a cloud-hosted Hub #851

Code changes

/
- resolve and deduplicate yarn.lock: get "one true version" of typescript, prettier, webpack
- add sourcemaps (we can take these out, but... would be really nice for downstream debugging)
.github
- bump more CI action versions to squash warnings
@jupyter-lsp/jupyterlab-lsp
- initialize LanguageServerManager with app.serviceManager.settingsis being used
- use these settings for doing API requests and WebSockets
- handle a race condition for very fast settings loading (no http request) for plugins with a PromiseDelegate
- update @jupyterlab/* dependencies to match python-level dependency
@jupyter-lsp/lsp-ws-connection
- use webpack 5 for lsp-ws-connection
- normalize void for handling of promises
- bumps version
jupyter_lsp
- use importlib(_|.)metadata for entrypoints
- bumps version
- defers language server spec discovery until the event loop is ready

User-facing changes

hopefully few visible changes

Backwards-incompatible changes

python
- downstreams which interact with jupyter_lsp.LanguageServerManager directly may need to await more things

Chores

linted
tested
documented
changelog entry

github-actions · 2022-12-10T22:21:55Z

👈 Launch a binder notebook on branch bollwyvl/jupyterlab-lsp/gh-880-mk2-use-server-http-settings

…mk2-use-server-http-settings

…gh-880-mk2-use-server-http-settings

bollwyvl · 2022-12-12T16:35:28Z

Ha, green!

I can roll back the server lazy loading changes if desired.

krassowski · 2022-12-17T17:15:50Z

python_packages/jupyterlab_lsp/setup.cfg

@@ -36,5 +36,5 @@ zip_safe = False
 python_requires = >=3.7

 install_requires =
- jupyter_lsp >=1.4.0
+ jupyter_lsp >=1.6.0


If this is required, should we consider making a major version bump?

Yeah, it's probably worth pulling this part onto a separate PR, and doing some manual reverts.

Also, of note, we might need to be very ginger with ipykernel 6.19.*. as i was seeing some message-related stuff that might confuse our test rig.

Let's keep going an release 2.0 then. I hope to get to releasing stuff over the break.

Just to clarify, which of the below:

make a new PR with this HEAD (perhaps force push to [wip] defer initialization until event loop is available #852) and this roll this back to not touch server

keep going on this, but instead of bumping to 1.6, bump to 2.0

Some background:

I guess it depends on how semver we're getting: the contract with the frontend doesn't actually change at all, but I am wary of not also testing against the oldest supported serverextension, whereas moving the pin makes it relatively clear.

The manager API does change a bit, to avoid paying for language server discovery. So if someone was overloading the manager, but using the stock routes, that could be an issue.

The listener API does not change.

keep going on this, but instead of bumping to 1.6, bump to 2.0

I was thinking this one. Especially if we could also get #636 in. Otherwise maybe 1.6 is fine.

So if someone was overloading the manager, but using the stock routes, that could be an issue.

Yes. I don't know of anyone who does that. I don't feel strong about this especially since we did not advertise support for overloading it like that.

Especially if we could also get #636 in.

That would be great.

Expounding a little further: should 2.0 be

python >=3.8

Ipykernel, etc. have already started to move on.

jupyter_server >=2.0

it's just going to be really messy for a while, but it will be a lot simpler to support

krassowski · 2022-12-18T15:22:19Z

packages/lsp-ws-connection/src/ws-connection.ts

@@ -1,5 +1,6 @@
 import * as events from 'events';

+import 'setimmediate';


Why is this needed? It looks as not maintained for a while now, and I am not sure where it gets used. Is this due to a setImmediate cal in one of dependencies?

a setImmediate cal in one of dependencies?

Deep in one of the vscode-* ones, and extremely hard to track down (hence the sourcemaps).

Maybe these instead: https://www.npmjs.com/package/timers-browserify

haha, uses that, too

bollwyvl · 2022-12-18T17:15:16Z

Cool, glad to have this one in.

I'll have another look at working the CI assets into the downstream on jupyterlite-lsp...

…p#882 Co-authored-by: Nicholas Bollweg <[email protected]>

* Use proper web socket URL, see jupyter-lsp/jupyterlab-lsp#819 Co-authored-by: Author: MikeSem <[email protected]> * Use app's HTTP settings, cherry-picked from jupyter-lsp/jupyterlab-lsp#882 Co-authored-by: Nicholas Bollweg <[email protected]> * Support optional `.virtual_documents` Cherry-picked from jupyter-lsp/jupyterlab-lsp#930 --------- Co-authored-by: Author: MikeSem <[email protected]> Co-authored-by: Nicholas Bollweg <[email protected]>

bollwyvl added 10 commits September 11, 2022 20:24

defer initialization until event loop is available

a957e61

[880] ws

26c9ee4

[880] dependencies and resolutions

6309405

[880] builder

eb71ed1

[880] reuse app http settings

5b431a0

[880] roll back prettier change

98c1d36

[880] deduplicate

3fe641e

[880] feature settings promisedelegate

a28ee70

[880] eslint settings

4e476a8

[880] linting

f65b5e9

bollwyvl added 9 commits December 11, 2022 09:23

Merge remote-tracking branch 'upsteam/master' into jupyter-lspgh-880-…

16876bd

…mk2-use-server-http-settings

linting

58d9561

linting, removing prettier churn

eca335d

update changelog

87bd259

bump lsp-ws-connection

a466620

bump to actions/cache@v3

15da0a2

bump ws dep back down for smoke

7603b46

normalize @jupyterlab/* version

66140a6

bump more action versions

f989a83

bollwyvl changed the title ~~Gh 880 mk2 use server http settings~~ Use server's http settings, handle feature settings race condition, CI/build updates Dec 11, 2022

bollwyvl changed the title ~~Use server's http settings, handle feature settings race condition, CI/build updates~~ Use app's HTTP settings, handle feature settings race condition, CI/build updates Dec 11, 2022

bollwyvl added 8 commits December 11, 2022 10:28

remove sharedPackages for source build

ac35714

clean up some use of setup-miniconda

a4fb737

squash some audit warnings

2608ab6

lawyer up, more naming

b4f02a8

more lawyering

87c1fb4

remove use of deprecated entrypoints

bd233fc

Merge branch 'jupyter-lspgh-851-lazy-initialization' into jupyter-lsp…

25d158b

…gh-880-mk2-use-server-http-settings

bump jupyter-lsp version

58ff3e1

server extension enable in postBuild

bf6e421

bollwyvl mentioned this pull request Dec 11, 2022

[wip] defer initialization until event loop is available #852

Closed

4 tasks

bollwyvl changed the title ~~Use app's HTTP settings, handle feature settings race condition, CI/build updates~~ Use app's HTTP settings, handle feature settings race condition, CI/build updates, lazy server discovery Dec 11, 2022

bollwyvl marked this pull request as ready for review December 11, 2022 22:32

bollwyvl requested a review from krassowski December 12, 2022 16:35

krassowski reviewed Dec 17, 2022

View reviewed changes

krassowski reviewed Dec 18, 2022

View reviewed changes

krassowski merged commit 389cc50 into jupyter-lsp:master Dec 18, 2022

This was referenced Mar 21, 2023

Slow first start #796

Closed

Slow startup on a cloud-hosted Hub #851

Open

krassowski added a commit to krassowski/jupyterlab that referenced this pull request Jun 18, 2023

Use app's HTTP settings, cherry-picked from jupyter-lsp/jupyterlab-ls…

5246f1d

…p#882 Co-authored-by: Nicholas Bollweg <[email protected]>

krassowski mentioned this pull request Jun 18, 2023

Port LSP connection manager fixes/enhancements jupyterlab/jupyterlab#14714

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use app's HTTP settings, handle feature settings race condition, CI/build updates, lazy server discovery #882

Use app's HTTP settings, handle feature settings race condition, CI/build updates, lazy server discovery #882

bollwyvl commented Dec 10, 2022 •

edited

github-actions bot commented Dec 10, 2022

bollwyvl commented Dec 12, 2022

krassowski Dec 17, 2022

bollwyvl Dec 18, 2022

krassowski Dec 18, 2022

bollwyvl Dec 18, 2022

krassowski Dec 18, 2022

bollwyvl Dec 18, 2022

krassowski Dec 18, 2022

bollwyvl Dec 18, 2022

bollwyvl Dec 18, 2022

bollwyvl Dec 18, 2022

bollwyvl commented Dec 18, 2022

		@@ -1,5 +1,6 @@
		import * as events from 'events';

		import 'setimmediate';

Use app's HTTP settings, handle feature settings race condition, CI/build updates, lazy server discovery #882

Use app's HTTP settings, handle feature settings race condition, CI/build updates, lazy server discovery #882

Conversation

bollwyvl commented Dec 10, 2022 • edited

References

Code changes

User-facing changes

Backwards-incompatible changes

Chores

github-actions bot commented Dec 10, 2022

bollwyvl commented Dec 12, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bollwyvl commented Dec 18, 2022

bollwyvl commented Dec 10, 2022 •

edited