[bash] bring fzf’s own bash completion up to date #3471
Conversation
This orders and groups completed options and values in just as they appear in the code respectively, for some option values, as they’d be printed in the `--help`-output. It does not add support for completion of `:` right after values that support an optional `:some-further-value` postfix. Neither does it add support for the `--option=value`-style. Signed-off-by: Christoph Anton Mitterer <[email protected]>
|
Thank you.
Completion for fzf itself is not my priority right now so it's not clear when I'm going to work on it. But what is clear is that I don't want to maintain three different implementations to provide the same functionality across bash, zsh, and fish. So yeah, Cobra (or any equivalent library) is the way to go.
I don't really remember. If it doesn't make any difference, we can drop it. |
Presumably, the dropped code is not needed for any effect, thus drop it. Signed-off-by: Christoph Anton Mitterer <[email protected]>
Uhm... well at least I can't see any difference. Though I'm not really a completion expert and there may be some side-effects that I just don't realise. It seems to have been added in 3b52811, but AFAICS there is no information on why the array is set to an empty one. I've added a commit on top that drops the part, and if it actually breaks something,... will blame everything on you. 😜😇 |
|
btw: Not a serious problem, but any reason for always squashing the commits? Makes cleaning up the local branches more work ^^ |
|
I squash when the intermediate changes are minor and don't provide much value to be seen separately. |
Well, I tried to find out all possible options and "fixed" values as good as I could from the actual parsing code.
Unfortunately both,
--help-output and the manpage seem to be also outdated (see #3470), so these were couldn’t really be used as a reference.Yeah,... I remember your comment in #3457 (comment) ... but it sounded rather unclear whether/when you'd go that "cobra"-way... and I don't want
fzf’s own completion to be dropped.So here's an update.
That being said, I still think we should do #3457, but maybe we can discuss that in terms of some larger ideas.
btw:
Why are you doing this:
fzf/shell/completion.bash
Lines 123 to 126 in a0d61b4
?
Can it be dropped?