Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTEL trace id to goroutine labels #17374

Merged
merged 1 commit into from
May 17, 2024

Conversation

SimonRichardson
Copy link
Member

To better integrate with 3rd party applications[1] and to identify goroutines that are related to OTEL traces, this adds labels to a goroutine.

This is another step forward to better understand the performance characteristics of how Juju operates in theatre.

  1. https://www.polarsignals.com/blog/posts/2024/03/05/correlating-tracing-with-profiling-using-ebpf

Checklist

  • Code style: imports ordered, good names, simple structure, etc
  • Comments saying why design decisions were made
  • Go unit tests, with comments saying what you're testing

QA steps

$ sudo snap install parca-agent
$ sudo snap set parca-agent metadata-external-labels=machine=<machine>
$ sudo snap set parca-agent remote-store-bearer-token=<token>
$ juju bootstrap lxd test

See the labels added to the profiles.

To better integrate with 3rd party applications[1] and to identify
goroutines that are related to OTEL traces, this adds labels to
a goroutine.

This is another step forward to better understand the performance
characteristics of how Juju operates in theatre.
@SimonRichardson
Copy link
Member Author

/build

Copy link
Member

@manadart manadart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well.

@SimonRichardson
Copy link
Member Author

/merge

@jujubot jujubot merged commit 8f53ac1 into juju:main May 17, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants