Domain errors #17255
Merged
Domain errors #17255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonRichardson
commented
Apr 23, 2024
SimonRichardson
force-pushed
the
fix-domain-errors
branch
from
6cb517f
to
2d275d1
Compare
SimonRichardson
force-pushed
the
fix-domain-errors
branch
from
4288e48
to
7a8b88e
Compare
This masks all sql, sqlite and dqlite errors so they're not available via errors.Is or errors.As. All errors should be trapped at the domain layer and not leaked outside. Thus the API client and server are never coupled to the underlying database errors. Dropping the older domain errors for specific domain type errors gives more focused errors that can be trapped at the API server layer.
We're dropping support for centeralized domain errors, so network needs it's own ones now.
SimonRichardson
force-pushed
the
fix-domain-errors
branch
from
7a8b88e
to
fdacdae
Compare
This adds a test to ensure that sql.ErrNoRows and other database sql errors are also not selectable. The error message is also preserved. This prevents the need for logging the error as well as returning the error.
The object store was leaking a sql error, ensure that we correctly trap the error.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This masks all sql, sqlite and dqlite errors so they're not available via errors.Is or errors.As. All errors should be trapped at the domain layer and not leaked outside. Thus the API client and server are never coupled to the underlying database errors.
Dropping the older domain errors for specific domain type errors gives more focused errors that can be trapped at the API server layer.
Checklist
QA steps
Links
Jira card: JUJU-