Ensure we can set migration phase to DONE idempotently. #16858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpidcock
added
3.6
decaying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a model has been migrated away, after reaping the model, the migration master sets the migration phase to DONE.
Although this should not have any consequence, as the phase is already set to DONE, we need to be idempotent here. If we are setting to DONE and the model doesn't exists and we are already DONE, we should continue without error.
QA steps
Unit tests should still pass.
Documentation changes
N/A
Links
alt-model-migration-controller-debug.log: machine-0: 11:24:57 ERROR juju.worker.dependency "migration-master" manifold worker returned unexpected error: failed to set phase: could not get migration: model "3a971d6b-338d-47aa-8cbd-f5fc83be4b2a" not found (not found)