Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short-circuit fileReader.visit function if visitor returns false #4783

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

polyrabbit
Copy link
Contributor

Avoid unnecessary loop

@davies
Copy link
Contributor

davies commented Apr 26, 2024

Have your saw actual performance difference?

@polyrabbit
Copy link
Contributor Author

Not yet. I didn't intentionally construct test cases for this scenario.
Just suppose it's a common practice in visitor pattern when reading the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants