Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] jsx-key: incorrect behavior for checkKeyMustBeforeSpread with map callbacks #3769

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented Jun 18, 2024

Fixes #3742

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.76%. Comparing base (393bfa2) to head (6dc7803).

Files Patch % Lines
lib/rules/jsx-key.js 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3769      +/-   ##
==========================================
+ Coverage   94.28%   97.76%   +3.47%     
==========================================
  Files         134      134              
  Lines        9613     9617       +4     
  Branches     3486     3488       +2     
==========================================
+ Hits         9064     9402     +338     
+ Misses        549      215     -334     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb ljharb force-pushed the akul/jsx-key-checkKeyMustBeforeSpread-arrmap-issue branch from 0091ac8 to 6dc7803 Compare June 18, 2024 18:21
@ljharb ljharb changed the title [Fix] jsx-key: incorrect behaviour for checkKeyMustBeforeSpread with map callbacks [Fix] jsx-key: incorrect behavior for checkKeyMustBeforeSpread with map callbacks Jun 18, 2024
@ljharb ljharb merged commit 6dc7803 into jsx-eslint:master Jun 18, 2024
329 of 330 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: checkKeyMustBeforeSpread of react/jsx-key doesn't work when generating array dynamically
2 participants