Don't make elements after enum part of enum 'module' #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andorbal
force-pushed
the
fix-enum-module
branch
2 times, most recently
from
409c000
to
b8e0e80
Compare
|
Hello, are there any reasons that blocks merge of this PR? |
|
Merge this 🙏 |
|
Can we please have this merged? It is 100% relevant and breaking protobuf.js pbts TypeScript from jsdoc conversion. |
pde-rent
approved these changes
Dec 19, 2020
|
Can this be merged yet? Its passed all checks for a month now. |
|
Bumping this issue |
|
+1 |
|
+1, breaking our typescript protobuf.js models as well |
|
Same issue here <3 |
|
+1 |
|
bump! pls merge :) |
courageon
approved these changes
Jun 13, 2021
antonstjernquist
approved these changes
Jun 13, 2021
|
I was looking at this commit. Shouldn't there be a 'module' and a 'member'? The enum shouldn't become a 'module'. |
|
Bump! Please merge 🙏 |
monikakalt
pushed a commit
to monikakalt/jsdoc
that referenced
this pull request
Mar 17, 2023
|
I updated according to latest version: #2046 could this be finally merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While generating a TypeScript declaration file for some protobuf messages, I came across a strange issue where no types after an enum was exported were included in the declaration file. I tracked the issue down to an issue in jsdoc where any export in a file after an enum is exported is considered to be a child of the enum. It looks like this behavior was added during a fix for #970.
The simple workaround for my case was to define the enum in a separate file, but I'd rather just fix the problem to avoid running into the same problem six months from now, forgetting the solution, and going through the process all over again!