forked from asciidwango/js-primer
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
アクセサ、アクセッサの表記をアクセッサに統一するように修正した #1
Draft
haruguchi-yuma
wants to merge
1,200
commits into
js-primer:master
Choose a base branch
from
haruguchi-yuma:patch-10
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix operator on class-instance-method sample code * fix from strict-not-equal-operator to strict-equal-operator
修正前:コールバック関数のcurrentValueには1から3の値が順番に渡されます。 修正後:コールバック関数の`仮引数である`currentValueには、1から3の値が順番に渡されます。
Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.3 to 3.9.4. - [Release notes](https://github.com/patriksimek/vm2/releases) - [Changelog](https://github.com/patriksimek/vm2/blob/master/CHANGELOG.md) - [Commits](patriksimek/vm2@3.9.3...3.9.4) --- updated-dependencies: - dependency-name: vm2 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.4. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md) - [Commits](axios/axios@v0.21.1...v0.21.4) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.6 to 1.19.7. - [Release notes](https://github.com/medialize/URI.js/releases) - [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md) - [Commits](medialize/URI.js@v1.19.6...v1.19.7) --- updated-dependencies: - dependency-name: urijs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…nd_yarn/vm2-3.9.4
…nd_yarn/axios-0.21.4
Bumps [ws](https://github.com/websockets/ws) from 7.3.0 to 7.5.6. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.3.0...7.5.6) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…nd_yarn/urijs-1.19.7
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.5 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.5...v2.8.9) --- updated-dependencies: - dependency-name: hosted-git-info dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…nd_yarn/ws-7.5.6
…nd_yarn/hosted-git-info-2.8.9
Bumps [object-path](https://github.com/mariocasciaro/object-path) from 0.11.5 to 0.11.8. - [Release notes](https://github.com/mariocasciaro/object-path/releases) - [Commits](https://github.com/mariocasciaro/object-path/commits/v0.11.8) --- updated-dependencies: - dependency-name: object-path dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [dot-prop](https://github.com/sindresorhus/dot-prop) from 4.2.0 to 4.2.1. - [Release notes](https://github.com/sindresorhus/dot-prop/releases) - [Commits](sindresorhus/dot-prop@v4.2.0...v4.2.1) --- updated-dependencies: - dependency-name: dot-prop dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
* feat(website): support "module" execution * chore: update plugin * chore: update plugin
* feat: Top-Level awaitに対応 * update * test: support ES2022 * update * update * update * update * update * update * update
…#1379) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* markedパッケージのバージョンを1.0.0から最新の4.0.10へ更新 * revert package-lock.json * marked@4に合った文章へ修正。
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) --- updated-dependencies: - dependency-name: ini dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…nd_yarn/dot-prop-4.2.1
…nd_yarn/ini-1.3.8
# は ES2022で構文として使われるため、#をprototypeの短縮語として使わないように変更 ## 基本ルール - セクションタイトル: - 正式名称の 「`Array.prototype.includes` メソッド 」を使う - 文中 - prototoypeメソッドは、「Arrayの`includes`メソッド」を使う - 静的メソッドの場合は、「 `Array.from` 静的メソッド 」と言うことで区別する - プロパティの場合は、「Objectの `a` プロパティ」という表現 - ~Class Fieldは `メンバー` と呼ぶ感じで、プロパティと区別~ まだ未定 - 例外 - CSSセレクタでのID指定: `div#result` はlintのオプションで例外としてる
Bumps [@sideway/formula](https://github.com/sideway/formula) from 3.0.0 to 3.0.1. - [Release notes](https://github.com/sideway/formula/releases) - [Commits](hapijs/formula@v3.0.0...v3.0.1) --- updated-dependencies: - dependency-name: "@sideway/formula" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…nd_yarn/source/use-case/todoapp/sideway/formula-3.0.1
* fix: 「条件分岐」において、まとめの中の break 文の説明にみだれがあるため、読みやすく改善 * Update source/basic/condition/README.md --------- Co-authored-by: azu <[email protected]>
まとめにて - 関数の宣言方法 - 関数を値として使う方法 - コールバック関数 - 関数式とArrow Function - メソッドの定義方法 という順番になっているが、本文は「関数式とArrow Function」→ 「コールバック関数」 という順番になっていたため、本文の順番に対応するように修正した。
ブラウザ環境やランタイム環境(Node)で確認したところ、再代入によって発生する例外はTypeErrorだったため修正しました。
Signed-off-by: azu <[email protected]>
Signed-off-by: azu <[email protected]>
Signed-off-by: azu <[email protected]>
* feat(meeting): 2023-02-16 Meeting Notes * feat: 2023-01-12 Meeting Notes
* fix: リンクが貼られていなかったため、修正 * リンクを末尾に移動 & 使用されていないリンクを削除 asciidwango#1587
* fix: 「関数とthis」における文の乱れを修正 * Merge suggestion
* fix: 「例外処理」における誤字修正 * Update prh.yml
* fix: 「クラス」における誤字修正や説明の改善 * Update source/basic/class/README.md Co-authored-by: azu <[email protected]> * Merge suggestions * Update source/basic/class/README.md Co-authored-by: azu <[email protected]> --------- Co-authored-by: azu <[email protected]>
Co-authored-by: keisuke kudo <[email protected]>
* fix: 「関数とスコープ」における誤字脱字の訂正など * 文の構造を更新
クラスのPrivateクラスフィールドの項にて、一箇所アクセサプロパティという記述があったため、アクセッサプロパティへと統一した。
haruguchi-yuma
force-pushed
the
patch-10
branch
from
February 21, 2023 15:19
8e74428
to
858d2c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
クラスのPrivateクラスフィールドの項で
「アクセサプロパティ」という表記があったが、その箇所以外は「アクセッサプロパティ」と記述されていたので統一するように修正しました。ご検討ください。