Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hook for Black formatting #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add pre-commit hook for Black formatting #11

wants to merge 1 commit into from

Conversation

andodet
Copy link

@andodet andodet commented Jan 8, 2021

Summary

Thanks for the interesting package, I can see it softening the burden of writing lots of boiler-plate code for standard-ish modeling tasks.

I've noticed code formatting with black is enforced in CONTRIBUTING.md. Might be a good idea to add a pre-commit hook to take that out of the equation when reviewing pull requests.

Details

Checklist

  • all tests are passing (see README.md on how to run tests)
  • if you created a new template: it contains a file test-inputs.yml, which specifies a few input values to test the code template (the test is then automatically run by pytest)
  • you formatted all code with black
  • you checked all new functionality live, i.e. in the running web app
  • any generated code is formatted nicely, both in .py and in .ipynb ("nicely" = comparable to the existing templates)
  • you added comments in your code that explain what it does
  • the PR explains in detail what's new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant