Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sorting in parallel requests
Problem:
When you draging several lines in few seconds and parallel request running to change position - its raise an unrepetable reading and the sort index in database became not unique. For example we have an table:
and two parallel requests
POST
adminsortable2_update: startorder: 2, endorder: 4POST
adminsortable2_update: startorder: 5, endorder: 3after first requests table will be:
after second request table will be:
Problem is duplicating sort index
4
in table.It apperas becouse second request had read table before changes from first query was applied - so second request moved
e
to 3d position and changed indexes ford
andc
as +1.Solition
To avoid this case we will lock all the range of changable rows